linux-kernel - [PATCH] usbip: tools: fix fd leakage in the function of read_attr_usbip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 Oct 2019 00:35:15 -0400
From:   Hewenliang <hewenliang4@...wei.com>
To:     <valentina.manea.m@...il.com>, <shuah@...nel.org>,
        <gregkh@...uxfoundation.org>, <allison@...utok.net>,
        <swinslow@...il.com>, <tglx@...utronix.de>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <linfeilong@...wei.com>, <hewenliang4@...wei.com>
Subject: [PATCH] usbip: tools: fix fd leakage in the function of read_attr_usbip_status

We should close the fd before the return of read_attr_usbip_status.

Fixes: 3391ba0e279 ("usbip: tools: Extract generic code to be shared with vudc backend")
Signed-off-by: Hewenliang <hewenliang4@...wei.com>
---
 tools/usb/usbip/libsrc/usbip_host_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c
index 2813aa821c82..d1d8ba2a4a40 100644
--- a/tools/usb/usbip/libsrc/usbip_host_common.c
+++ b/tools/usb/usbip/libsrc/usbip_host_common.c
@@ -57,7 +57,7 @@ static int32_t read_attr_usbip_status(struct usbip_usb_device *udev)
 	}
 
 	value = atoi(status);
-
+	close(fd);
 	return value;
 }
 
-- 
2.19.1