linux-kernel - Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHX4x87jLHxZwvaU6nAX5VKy=LZutiRohE6rGd1GffJg-Pt0JA@mail.gmail.com>
Date:   Fri, 25 Oct 2019 13:18:18 -0600
From:   Nick Crews <ncrews@...omium.org>
To:     Daniel Campello <campello@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Benson Leung <bleung@...omium.org>, linux-leds@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Duncan Laurie <dlaurie@...omium.org>,
        Daniel Kurtz <djkurtz@...omium.org>,
        Dmitry Torokhov <dtor@...gle.com>,
        Simon Glass <sjg@...omium.org>, groeck@...omium.com
Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight
 LED support

On Fri, Oct 25, 2019 at 11:33 AM Daniel Campello <campello@...omium.org> wrote:
>
> LGTM.
> Reviewed-by: Daniel Campello <campello@...omium.

FYI I realized some of the imports in keyboard_leds.c are
unneeded, so I sent a v8 version that fixes this. I presume
you would LGTM that one too though.