linux-kernel - Re: [PATCH] drm/amd/display: remove gcc warning Wunused-but-set-variable

Open Source and information security mailing list archives

Message-ID: <CADnq5_NiuOrH48a9qscT60kzhcSCgmRF8dmBj4Ga9Lkh_L1+4w@mail.gmail.com>
Date:   Fri, 25 Oct 2019 15:22:31 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Chen Wandun <chenwandun@...wei.com>
Cc:     "Wentland, Harry" <harry.wentland@....com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        David Francis <David.Francis@....com>,
        "Cheng, Tony" <Tony.Cheng@....com>, abdoulaye.berthe@....com,
        Thomas Lim <Thomas.Lim@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: remove gcc warning Wunused-but-set-variable

On Sat, Oct 19, 2019 at 8:07 PM Chen Wandun <chenwandun@...wei.com> wrote:
>
> From: Chenwandun <chenwandun@...wei.com>
>
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.c: In function dce_aux_configure_timeout:
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.c: warning: variable timeout set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Chenwandun <chenwandun@...wei.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 976bd49..739f8e2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -432,7 +432,6 @@ static bool dce_aux_configure_timeout(struct ddc_service *ddc,
>  {
>         uint32_t multiplier = 0;
>         uint32_t length = 0;
> -       uint32_t timeout = 0;
>         struct ddc *ddc_pin = ddc->ddc_pin;
>         struct dce_aux *aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
>         struct aux_engine_dce110 *aux110 = FROM_AUX_ENGINE(aux_engine);
> @@ -446,25 +445,21 @@ static bool dce_aux_configure_timeout(struct ddc_service *ddc,
>                 length = timeout_in_us/TIME_OUT_MULTIPLIER_8;
>                 if (timeout_in_us % TIME_OUT_MULTIPLIER_8 != 0)
>                         length++;
> -               timeout = length * TIME_OUT_MULTIPLIER_8;
>         } else if (timeout_in_us <= 2 * TIME_OUT_INCREMENT) {
>                 multiplier = 1;
>                 length = timeout_in_us/TIME_OUT_MULTIPLIER_16;
>                 if (timeout_in_us % TIME_OUT_MULTIPLIER_16 != 0)
>                         length++;
> -               timeout = length * TIME_OUT_MULTIPLIER_16;
>         } else if (timeout_in_us <= 4 * TIME_OUT_INCREMENT) {
>                 multiplier = 2;
>                 length = timeout_in_us/TIME_OUT_MULTIPLIER_32;
>                 if (timeout_in_us % TIME_OUT_MULTIPLIER_32 != 0)
>                         length++;
> -               timeout = length * TIME_OUT_MULTIPLIER_32;
>         } else if (timeout_in_us > 4 * TIME_OUT_INCREMENT) {
>                 multiplier = 3;
>                 length = timeout_in_us/TIME_OUT_MULTIPLIER_64;
>                 if (timeout_in_us % TIME_OUT_MULTIPLIER_64 != 0)
>                         length++;
> -               timeout = length * TIME_OUT_MULTIPLIER_64;
>         }
>
>         length = (length < MAX_TIMEOUT_LENGTH) ? length : MAX_TIMEOUT_LENGTH;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives