linux-kernel - Re: [PATCH] dc.c:use kzalloc without test

Open Source and information security mailing list archives

Message-ID: <CADnq5_Nv9j5vDX5-Jkhy3TTiej7FcKBBOC8QQk59NQ=SsO-3pg@mail.gmail.com>
Date:   Fri, 25 Oct 2019 15:32:48 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harry Wentland <hwentlan@....com>
Cc:     zhongshiqi <zhong.shiqi@....com.cn>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Lei, Jun" <Jun.Lei@....com>, "Koo, Anthony" <Anthony.Koo@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "David.Francis@....com" <David.Francis@....com>,
        "Liu, Wenjing" <Wenjing.Liu@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "cheng.shengyu@....com.cn" <cheng.shengyu@....com.cn>,
        "wang.yi59@....com.cn" <wang.yi59@....com.cn>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Aidan.Wood@....com" <Aidan.Wood@....com>,
        "xue.zhihong@....com.cn" <xue.zhihong@....com.cn>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
        "Park, Chris" <Chris.Park@....com>,
        "Yang, Eric" <Eric.Yang2@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Laktyushkin, Dmytro" <Dmytro.Laktyushkin@....com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@....com>
Subject: Re: [PATCH] dc.c:use kzalloc without test

Applied.  thanks!

Alex

On Wed, Oct 23, 2019 at 9:35 AM Harry Wentland <hwentlan@....com> wrote:
>
> On 2019-10-23 4:32 a.m., zhongshiqi wrote:
> > dc.c:583:null check is needed after using kzalloc function
> >
> > Signed-off-by: zhongshiqi <zhong.shiqi@....com.cn>
>
> Reviewed-by: Harry Wentland <harry.wentland@....com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 5d1aded..4b8819c 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -580,6 +580,10 @@ static bool construct(struct dc *dc,
> >  #ifdef CONFIG_DRM_AMD_DC_DCN2_0
> >       // Allocate memory for the vm_helper
> >       dc->vm_helper = kzalloc(sizeof(struct vm_helper), GFP_KERNEL);
> > +     if (!dc->vm_helper) {
> > +             dm_error("%s: failed to create dc->vm_helper\n", __func__);
> > +             goto fail;
> > +     }
> >
> >  #endif
> >       memcpy(&dc->bb_overrides, &init_params->bb_overrides, sizeof(dc->bb_overrides));
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives