linux-kernel - Re: [Outreachy kernel] [Outreachy][PATCH] drm: use DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191025194029.GU11828@phenom.ffwll.local>
Date:   Fri, 25 Oct 2019 21:40:29 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Wambui Karuga <wambui.karugax@...il.com>,
        dri-devel@...ts.freedesktop.org, maarten.lankhorst@...ux.intel.com,
        mripard@...nel.org, sean@...rly.run, airlied@...ux.ie,
        daniel@...ll.ch, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [Outreachy][PATCH] drm: use DIV_ROUND_UP
 helper macro for calculations

On Fri, Oct 25, 2019 at 12:12:23PM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 25 Oct 2019, Wambui Karuga wrote:
> 
> > Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> > macro for better readability.
> > Issue found using coccinelle:
> > @@
> > expression n,d;
> > @@
> > (
> > - ((n + d - 1) / d)
> > + DIV_ROUND_UP(n,d)
> > |
> > - ((n + (d - 1)) / d)
> > + DIV_ROUND_UP(n,d)
> > )
> >
> > Signed-off-by: Wambui Karuga <wambui.karugax@...il.com>
> 
> Acked-by: Julia Lawall <julia.lawall@...6.fr>

Applied to drm-misc-next, thanks for your patch.
-Daniel

> 
> 
> > ---
> >  drivers/gpu/drm/drm_agpsupport.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c
> > index 6e09f27fd9d6..4c7ad46fdd21 100644
> > --- a/drivers/gpu/drm/drm_agpsupport.c
> > +++ b/drivers/gpu/drm/drm_agpsupport.c
> > @@ -212,7 +212,7 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request)
> >  	if (!entry)
> >  		return -ENOMEM;
> >
> > -	pages = (request->size + PAGE_SIZE - 1) / PAGE_SIZE;
> > +	pages = DIV_ROUND_UP(request->size, PAGE_SIZE);
> >  	type = (u32) request->type;
> >  	memory = agp_allocate_memory(dev->agp->bridge, pages, type);
> >  	if (!memory) {
> > @@ -325,7 +325,7 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request)
> >  	entry = drm_agp_lookup_entry(dev, request->handle);
> >  	if (!entry || entry->bound)
> >  		return -EINVAL;
> > -	page = (request->offset + PAGE_SIZE - 1) / PAGE_SIZE;
> > +	page = DIV_ROUND_UP(request->offset, PAGE_SIZE);
> >  	retcode = drm_bind_agp(entry->memory, page);
> >  	if (retcode)
> >  		return retcode;
> > --
> > 2.23.0
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025094907.3582-1-wambui.karugax%40gmail.com.
> >

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch