linux-kernel - RE: [PATCH] namespace: fix namespace.pl script to support relative paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB589693DABC@ORSMSX121.amr.corp.intel.com>
Date:   Fri, 25 Oct 2019 20:20:51 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: RE: [PATCH] namespace: fix namespace.pl script to support relative
 paths

> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Friday, October 25, 2019 12:30 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; Masahiro Yamada
> <yamada.masahiro@...ionext.com>
> Cc: intel-wired-lan@...ts.osuosl.org; linux-kernel@...r.kernel.org; linux-kbuild
> <linux-kbuild@...r.kernel.org>
> Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative
> paths
> 
> On 10/25/19 10:45 AM, Keller, Jacob E wrote:
> >
> >> -----Original Message-----
> >> From: Masahiro Yamada <yamada.masahiro@...ionext.com>
> >> Sent: Wednesday, October 23, 2019 6:22 PM
> >> To: Keller, Jacob E <jacob.e.keller@...el.com>
> >> Cc: Randy Dunlap <rdunlap@...radead.org>; intel-wired-lan@...ts.osuosl.org;
> >> linux-kernel@...r.kernel.org; linux-kbuild <linux-kbuild@...r.kernel.org>
> >> Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative
> >> paths
> >>
> >> If you want to detect missing 'static',
> >> have you tried 'sparse'?
> >>
> >
> > We've used that as well.
> >
> > To be fair, I agree that it covers similar functionality as other tools. I haven't
> looked directly at namespace.pl output in a while, and the fix here is multiple
> years old that took a long time to get picked up.
> >
> > If it's agreed that the tool has no value, and especially if it results in false
> indications of a problem, then maybe removing it to prevent someone from mis-
> reading its output makes sense?
> 
> If there is a satisfactory alternative, I expect that namespace.pl is old,
> unmaintained, and unneeded, and should go away.
> 
> --
> ~Randy

Given Yamada's comments and my experience, modpost and sparse are both good at detecting the issues that namespace.pl handles.

I am not sure if there's any other output that would be valuable from namespace.pl, but if not.. I don't see a reason to keep it compared to the other tools.

Thanks,
Jake