linux-kernel - Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3aed0c75-80e7-cc9d-59f9-6ef29b665efc@amd.com>
Date:   Fri, 25 Oct 2019 06:53:16 +0000
From:   vishnu <vravulap@....com>
To:     Mark Brown <broonie@...nel.org>,
        "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>
CC:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Maruthi Bayyavarapu <maruthi.bayyavarapu@....com>,
        Colin Ian King <colin.king@...onical.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        "Mehta, Sanju" <Sanju.Mehta@....com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI

Hi Mark,

My inline responses.

On 24/10/19 5:10 PM, Mark Brown wrote:
> On Sat, Oct 19, 2019 at 02:35:41AM +0530, Ravulapati Vishnu vardhan rao wrote:
> 
>> +		case I2S_BT_INSTANCE:
>> +			val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
>> +			val = val | (rtd->xfer_resolution  << 3);
>> +			rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
>> +		break;
> 
> For some reason the break; isn't indented with the rest of the block.
> I'm fairly sure I've mentioned this before...
Sorry for this but I am not able to find indentation.I have tested with 
scripts/checkpatch.pl. It shows no warnings.
> 
>> +		case I2S_SP_INSTANCE:
>> +		default:
>> +			val = rv_readl(rtd->acp3x_base + mmACP_I2STDM_ITER);
>> +			val = val | (rtd->xfer_resolution  << 3);
>> +			rv_writel(val, rtd->acp3x_base + mmACP_I2STDM_ITER);
>> +		}
> 
> Missing break; here - again it's normal kernel coding style to include
> it.I will create a separate patch for rectifying this.Thank you.
> 
>> +	struct snd_soc_pcm_runtime *prtd = substream->private_data;
>> +	struct snd_soc_card *card = prtd->card;
>> +	struct acp3x_platform_info *pinfo = snd_soc_card_get_drvdata(card);
>> +
>> +	if (pinfo) {
>> +		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>> +			rtd->i2s_instance = pinfo->play_i2s_instance;
>> +		else
>> +			rtd->i2s_instance = pinfo->cap_i2s_instance;
>> +	}
> 
> Looks like you need an error handling case here if pinfo is missing,
> i2s_instance needs to be set.  There are default cases but it's not
> clear that that's a good idea, the intent of the code is clearly that
> there's always platform data.
> 
Yes my intention is It should always have platformdata.