linux-kernel - Re: [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191025080655.GF32742@smile.fi.intel.com>
Date:   Fri, 25 Oct 2019 11:06:55 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Andrey Zhizhikin <andrey.z@...il.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org,
        Andrey Zhizhikin <andrey.zhizhikin@...ca-geosystems.com>
Subject: Re: [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove
 PMIC

On Thu, Oct 24, 2019 at 02:29:39PM +0000, Andrey Zhizhikin wrote:
> Add a regulator mfd cell to Whiskey Cove PMIC driver, which is used to
> supply various voltage rails.
> 
> In addition, make the initialization of this mfd driver early enough in
> order to provide regulator cell to mmc sub-system when it is initialized.

Doesn't deferred probe mechanism work for you?
MMC core returns that error till we have the driver initialized.

> +	}, {
> +		.name = "cht_wcove_regulator",
> +		.id = CHT_WC_REGULATOR_VSDIO + 1,

> +		.num_resources = 0,
> +		.resources = NULL,

No need to put these.

> -static struct i2c_driver cht_wc_driver = {
> +static struct i2c_driver cht_wc_i2c_driver = {

Renaming is not explained in the commit message.

-- 
With Best Regards,
Andy Shevchenko