linux-kernel - Re: [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lft9p3wi.fsf@FE-laptop>
Date:   Fri, 25 Oct 2019 11:31:41 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     YueHaibing <yuehaibing@...wei.com>, jason@...edaemon.net,
        andrew@...n.ch, sebastian.hesselbarth@...il.com,
        linus.walleij@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon

YueHaibing <yuehaibing@...wei.com> writes:

> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

I am against this patch, I don't see any value of this change. It will
only make backporting future fix more difficult and will obscurate the
git blame.

I could see the interest of scripts/coccinelle/misc/semicolon.cocci
when submitting new code, but not for existing code.

Gregory

> ---
>  drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 9df4277..fd32989 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -733,7 +733,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
>  			ret = 0;
>  			break;
>  		}
> -	};
> +	}
>  	if (ret) {
>  		dev_err(dev, "no gpio-controller child node\n");
>  		return ret;
> @@ -800,7 +800,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev,
>  			ret = 0;
>  			break;
>  		}
> -	};
> +	}
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.7.4
>
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com