linux-kernel - Re: [PATCH] KVM: avoid unnecessary bitmap clear ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5a9c7a85a5b14542ab773d5a5e454286@huawei.com>
Date:   Fri, 25 Oct 2019 09:49:31 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
CC:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: avoid unnecessary bitmap clear ops


On 25/10/19 17:43, Paolo wrote:
> On 25/10/19 04:24, Miaohe Lin wrote:
>> When set one bit in bitmap, there is no need to clear it before.
>
>Hi,
>
>in general the Linux coding style prefers:
>
>	a = x;
>	if (...);
>		a = y;
>
>to
>
>	if (...)
>		a = y;
>	else
>		a = x;
>
>which is why these lines were written this way.

Many thanks for your explanation. I see.
Have a nice day.

>
>Thanks,
>
>Paolo
>