linux-kernel - Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b020e8fe-d5c1-3544-c2b4-79ff4af3f85e@amd.com>
Date:   Fri, 25 Oct 2019 10:01:37 +0000
From:   vishnu <vravulap@....com>
To:     Mark Brown <broonie@...nel.org>
CC:     "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Maruthi Bayyavarapu <maruthi.bayyavarapu@....com>,
        Colin Ian King <colin.king@...onical.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        "Mehta, Sanju" <Sanju.Mehta@....com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI



On 25/10/19 3:25 PM, Mark Brown wrote:
> On Fri, Oct 25, 2019 at 06:53:16AM +0000, vishnu wrote:
>> On 24/10/19 5:10 PM, Mark Brown wrote:
>>> On Sat, Oct 19, 2019 at 02:35:41AM +0530, Ravulapati Vishnu vardhan rao wrote:
> 
>>>> +		case I2S_BT_INSTANCE:
>>>> +			val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> +			val = val | (rtd->xfer_resolution  << 3);
>>>> +			rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> +		break;
> 
>>> For some reason the break; isn't indented with the rest of the block.
>>> I'm fairly sure I've mentioned this before...
> 
>> Sorry for this but I am not able to find indentation.I have tested with
>> scripts/checkpatch.pl. It shows no warnings.
> 
> The break should be aligned with the rest of the block like I said, an
> extra tab in - you can see lots of examples of break statements in the
> kernel.
> 
Yes Got it.Thanks for your comments.I will create a separate patch for 
fixing this issue.

Regards,
Vishnu