linux-kernel - Re: [PATCH] x86/kvm: Fix -Wmissing-prototypes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <07bbeb02-e8fe-36d5-a761-402a48fe076f@redhat.com>
Date:   Fri, 25 Oct 2019 14:02:19 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     wang.yi59@....com.cn, kvm@...r.kernel.org
Cc:     rkrcmar@...hat.com, sean.j.christopherson@...el.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        joro@...tes.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, x86@...nel.org,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        up2wing@...il.com, wang.liang82@....com.cn
Subject: Re: [PATCH] x86/kvm: Fix -Wmissing-prototypes warnings

Queued, thanks.  It may not appear on git.kernel.org until after KVM
Forum though.

Paolo

On 25/10/19 03:58, wang.yi59@....com.cn wrote:
> Gentle Ping :)
> 
>> We get two warning when build kernel with W=1:
>> arch/x86/kernel/kvm.c:872:6: warning: no previous prototype for ‘arch_haltpoll_enable’ [-Wmissing-prototypes]
>> arch/x86/kernel/kvm.c:885:6: warning: no previous prototype for ‘arch_haltpoll_disable’ [-Wmissing-prototypes]
>>
>> Including the missing head file can fix this.
>>
>> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
>> ---
>>  arch/x86/kernel/kvm.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index e820568..32ef1ee 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -33,6 +33,7 @@
>>  #include <asm/apicdef.h>
>>  #include <asm/hypervisor.h>
>>  #include <asm/tlb.h>
>> +#include <asm/cpuidle_haltpoll.h>
>>
>>  static int kvmapf = 1;
> 
> 
> ---
> Best wishes
> Yi Wang
>