linux-kernel - Re: [PATCH v2 1/4] perf: Allow using AUX data in perf samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878sp9ggna.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Fri, 25 Oct 2019 15:21:13 +0300
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        jolsa@...hat.com, adrian.hunter@...el.com,
        mathieu.poirier@...aro.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v2 1/4] perf: Allow using AUX data in perf samples

Peter Zijlstra <peterz@...radead.org> writes:

>> @@ -6511,6 +6629,13 @@ void perf_output_sample(struct perf_output_handle *handle,
>>  	if (sample_type & PERF_SAMPLE_PHYS_ADDR)
>>  		perf_output_put(handle, data->phys_addr);
>>  
>> +	if (sample_type & PERF_SAMPLE_AUX) {
>> +		perf_output_put(handle, data->aux_size);
>> +
>> +		if (data->aux_size)
>> +			perf_aux_sample_output(event, handle, data);
>> +	}
>> +
>>  	if (!event->attr.watermark) {
>>  		int wakeup_events = event->attr.wakeup_events;
>
>
> So, afaict, you can simply remove the line in perf_sample_data_init().

That's right, thanks for catching this.

Regards,
--
Alex