linux-kernel - Re: [PATCH v3 01/13] dt-bindings: display: Convert common panel bindings to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Oct 2019 15:07:04 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh@...nel.org>
Cc:     DRI Development <dri-devel@...ts.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v3 01/13] dt-bindings: display: Convert common panel
 bindings to DT schema

Hi Rob,

On Fri, Jul 5, 2019 at 6:46 PM Rob Herring <robh@...nel.org> wrote:
> Convert the common panel bindings to DT schema consolidating scattered
> definitions to a single schema file.
>
> The 'simple-panel' binding just a collection of properties and not a
> complete binding itself. All of the 'simple-panel' properties are
> covered by the panel-common.txt binding with the exception of the
> 'no-hpd' property, so add that to the schema.
>
> As there are lots of references to simple-panel.txt, just keep the file
> with a reference to common.yaml for now until all the bindings are
> converted.
>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: dri-devel@...ts.freedesktop.org
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> Reviewed-by: Maxime Ripard <maxime.ripard@...tlin.com>
> Reviewed-by: Thierry Reding <treding@...dia.com>
> Signed-off-by: Rob Herring <robh@...nel.org>

This is now commit 821a1f7171aeea5e ("dt-bindings: display: Convert
common panel bindings to DT schema").

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml

> +  backlight:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      For panels whose backlight is controlled by an external backlight
> +      controller, this property contains a phandle that references the
> +      controller.

This paragraph seems to apply to all nodes named "backlight", causing
e.g. (for ARCH=arm mach_shmobile_defconfig) "make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/panel-common.yaml"
to start complaining:

    arch/arm/boot/dts/r8a7740-armadillo800eva.dt.yaml: backlight:
{'compatible': ['pwm-backlight'], 'pwms': [[40, 2, 33333, 1]],
'brightness-levels': [[0, 1, 2, 4, 8, 16, 32, 64, 128, 255]],
'default-brightness-level': [[9]], 'pinctrl-0': [[41]],
'pinctrl-names': ['default'], 'power-supply': [[42]], 'enable-gpios':
[[15, 61, 0]]} is not of type 'array'
    arch/arm/boot/dts/r8a7740-armadillo800eva.dt.yaml: backlight:
{'groups': ['tpu0_to2_1'], 'function': ['tpu0'], 'phandle': [[41]]} is
not of type 'array'

Do you know what's wrong?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds