linux-kernel - Re: [PATCH v6] platform/chrome: wilco_ec: Add Wilco EC keyboard backlight LEDs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191025173547.GB1768@chromium.org>
Date:   Fri, 25 Oct 2019 11:35:47 -0600
From:   Daniel Campello <campello@...omium.org>
To:     Nick Crews <ncrews@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Benson Leung <bleung@...omium.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Duncan Laurie <dlaurie@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH v6] platform/chrome: wilco_ec: Add Wilco EC keyboard
 backlight LEDs support

Thanks Nick for taking care of this. I just reviewed your patch
in the other thread. Also, thanks Enric for your comments.

Thanks again.
Daniel

On Thu, Oct 24, 2019 at 04:18:07PM -0600, Nick Crews wrote:
> Thanks for getting this going again Daniel. This version of
> the patch is fairly old, and after so long I've found some
> things about it that I don't like, even though I wrote it
> originally :). One of the main things was how complicated it
> was, and how there was duplicated code in core.c and the
> kbd_backlight_leds.c.
>
> Therefore, I just sent a newer version of this that simplifies
> things greatly, and addresses the feedback that Enric just gave.
> Check for that patch (it's paired with another unrelated one)
> and see what you think.
>
> Cheers,
> Nick
>
> On Thu, Oct 24, 2019 at 3:54 AM Enric Balletbo i Serra
> <enric.balletbo@...labora.com> wrote:
> >
> > Hi Daniel,
> >
> > Some few comments, mostly nits. In general I'm fine with it.
> >
> > Thanks,
> >  Enric