linux-kernel - Re: [PATCH v2] KVM: x86: get rid of odd out jump label in pdptrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <061ecabeb60442dbb6ce43c9aeb23562@huawei.com>
Date:   Sat, 26 Oct 2019 01:29:32 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
CC:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] KVM: x86: get rid of odd out jump label in
 pdptrs_changed


On 26/10/19 , Paolo Bonzini wrote:
> Queued, thanks (but it likely won't be on git.kernel.org until after the end of KVM Forum, sorry about that).

Not at all. Many thanks for your contribution to make KVM more strong, statble and efficient.
Have a nice day.

> On 25/10/19 12:54, Miaohe Lin wrote:
>> The odd out jump label is really not needed. Get rid of it by return 
>> true directly while r < 0 as suggested by Paolo. This further lead to 
>> var changed being unused.
>> Remove it too.