linux-kernel - Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b1f48d4-c1ec-22db-3bf9-d42d94c29e8e@puri.sm>
Date:   Sat, 26 Oct 2019 20:23:38 +0200
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        viresh.kumar@...aro.org, leo.yan@...aro.org, edubezval@...il.com,
        vincent.guittot@...aro.org, javi.merino@...nel.org,
        rui.zhang@...el.com, daniel.thompson@...aro.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu
 idle cooling driver

On 25.10.19 16:45, Daniel Lezcano wrote:
> 
> Hi Martin,
> 
> On 25/10/2019 13:22, Martin Kepplinger wrote:
>> Hi Daniel,
>>
>> Quick note: You're missing a kref_init() in this version of the cooling driver.
>>
>> Also, as already mentioned, set_freezable() doesn't seem to work without
>> supporting suspend/resume.
> 
> Right, it is removed.
> 
>> And since cpuidle got somewhat completely reworked in 5.4, could you create
>> a new, rebased version of this? Let me know in case I missed an earlier update.
> 
> Yes, I'm on it. There is a bug in the cpuidle registering I'm
> investigating right now. If you want I can put a branch with the idle
> injection cooling device as soon as it is fixed.
> 
> Note most of the patches are now merged. The cpuidle cooling device was
> split into the idle injection mechanism in the drivers/powercap [1] and
> the cooling device initialization which is the part to be merged.
> 
> The idle injection resolution was increased [2].
> 
> The idle state injection selection is currently in the review process [3].
> 
> The remaining part is the thermal cooling device itself which is a
> separated cooling device from the existing cpu one.
> 
>   -- Daniel
> 
> [1] https://lwn.net/Articles/757393/
> [2] https://patchwork.kernel.org/patch/11074003/
> [3] https://lkml.org/lkml/2019/9/9/447
> 

Hi Daniel,

Putting up a branch may make sense and seems like it would make testing
easy. I'll definitely try to test early as soon as you have the pieces
in place one way or another :)

thanks for your work on this,
                                martin