linux-kernel - Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Oct 2019 06:43:46 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Cristiane Naves <cristianenavescardoso09@...il.com>
cc:     outreachy-kernel@...glegroups.com,
        Rob Springer <rspringer@...gle.com>,
        Todd Poynor <toddpoynor@...gle.com>,
        Ben Chan <benchan@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines
 ending with a '('



On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix lines ending with a '('. Issue found by checkpatch.

You sent another patch on this file (the one I acked) and they are notin a
series, so Greg won't know how to apply them.  Please collect the whole
thing again, and either put both changes in the same patch, or send a
series with the different changes on this file.  You could put v2, so that
Greg knows to ignore your other changes on the file.

julia

>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@...il.com>
> ---
>  drivers/staging/gasket/gasket_ioctl.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index d1b3e9a..e3047d3 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
>  	ibuf.size = gasket_page_table_num_entries(
>  		gasket_dev->page_table[ibuf.page_table_index]);
>
> -	trace_gasket_ioctl_page_table_data(
> -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> -		ibuf.device_address);
> +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +					   ibuf.host_address,
> +					   ibuf.device_address);
>
>  	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
>  		return -EFAULT;
> @@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
>  	if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
>  		return -EFAULT;
>
> -	trace_gasket_ioctl_page_table_data(
> -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> -		ibuf.device_address);
> +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +					   ibuf.host_address,
> +					   ibuf.device_address);
>
>  	if (ibuf.page_table_index >= gasket_dev->num_page_tables)
>  		return -EFAULT;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025232935.GA813%40cristiane-Inspiron-5420.
>