lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <4d2b5e56-48ba-4af5-e7c6-b6171210cb32@lwfinger.net>
Date:   Sun, 27 Oct 2019 12:46:09 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Saurav Girepunje <saurav.girepunje@...il.com>, pkshih@...ltek.com,
        kvalo@...eaurora.org, davem@...emloft.net,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] net: wireless: realtek: rtlwifi: rtl8192c:Drop condition
 with no effect

On 10/27/19 1:23 AM, Saurav Girepunje wrote:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> ---

The patch is OK; however, the subject should be: rtlwifi: rtl8192c-common: Drop ...

We do not use the directory tree in the subject. By convention, it is the driver 
directory and the driver name. It is common for the driver name to match that of 
the top-level directory, but not in this case.

Thanks,

Larry

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ