lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20191027230921.205251-7-gwendal@chromium.org>
Date:   Sun, 27 Oct 2019 16:09:09 -0700
From:   Gwendal Grignou <gwendal@...omium.org>
To:     briannorris@...omium.org, jic23@...nel.org, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, lee.jones@...aro.org,
        bleung@...omium.org, enric.balletbo@...labora.com,
        dianders@...omium.org, groeck@...omium.org,
        fabien.lahoudere@...labora.com
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Enrico Granata <egranata@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>
Subject: [PATCH v3 06/18] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number

From: Enrico Granata <egranata@...omium.org>

Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.

Signed-off-by: Enrico Granata <egranata@...omium.org>
Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
---
No changes in v3.
Changes in v2:
  Remove dual Enrico's signature.

 drivers/platform/chrome/cros_ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 739f3cffe26e3..9b19f50572313 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 		return err;
 	}
 
-	if (ec_dev->irq) {
+	if (ec_dev->irq > 0) {
 		err = devm_request_threaded_irq(
 				dev, ec_dev->irq, ec_irq_handler,
 				ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
-- 
2.23.0.866.gb869b98d4c-goog

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ