linux-kernel - Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Oct 2019 13:14:41 +0100
From:   Stefan Wahren <wahrenst@....net>
To:     Daniel Wagner <dwagner@...e.de>, netdev@...r.kernel.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Woojung Huh <woojung.huh@...rochip.com>,
        Marc Zyngier <maz@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling
 generic_handle_irq()

Hi Daniel,

Am 25.10.19 um 10:04 schrieb Daniel Wagner:
> ...
>
> Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
> Cc: Woojung Huh <woojung.huh@...rochip.com>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Stefan Wahren <wahrenst@....net>
> Cc: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: David Miller <davem@...emloft.net>
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
>
> Hi,
>
> This patch just fixes the warning. There are still problems left (the
> unstable NFS report from me) but I suggest to look at this
> separately. The initial patch to revert all the irqdomain code might
> just hide the problem. At this point I don't know what's going on so I
> rather go baby steps. The revert is still possible if nothing else
> works.

did you ever see this pseudo lan78xx-irqs fire? I examined
/proc/interrupts on RPi 3B+ and always saw a 0.

FWIW you can have:

Tested-by: Stefan Wahren <wahrenst@....net>

for this patch.

Regards
Stefan