linux-kernel - Re: detecting misuse of of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191028224914.enpqjkcvbxyeexnl@desk.local>
Date:   Mon, 28 Oct 2019 23:49:15 +0100
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Dan Carpenter <dan.carpenter@...cle.co>,
        linux-sparse@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: detecting misuse of of_get_property

On Mon, Oct 28, 2019 at 08:32:42PM +0100, Rasmus Villemoes wrote:
> Hi,
> 
> I just spent some time trying to convert some so far PPC-only drivers to
> be more generic. One of the things I had to do was convert stuff like
> 
>   u32 *val = of_get_property(np, "bla", NULL);
>   do_stuff_with(*val);
> 
> with
> 
>   of_property_read_u32(np, "bla", &val);
>   do_stuff_with(val);
> 
> (error checking omitted for simplicity). The problem is that
> of_get_property() just returns void*. When the property is just a
> string, there's no problem interpreting that as a char*. But when the
> property is a number of array of numbers, I'd like some way to flag
> casting it to u32* as an error - if you cast it to a (pointer to integer
> type wider than char), it must be to a __be32*. Is there some way
> sparse/smatch could help find such cases?

If I understand you correctly, you would need a kind of 'soft'
bitwise pointer?
I guess it shouldn't be too hard to add a new flag which would
allow cast of bitwise pointers to pointers to char/void (see
at end of evaluate.c:evaluate_cast()).

Note: casts from bitwise pointer to void* are already allowed.

-- Luc