linux-kernel - AW: [PATCH 0/8] Face lift for st1232 touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 07:28:51 +0000
From:   Matthias Fend <Matthias.Fend@...fvision.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Martin Kepplinger <martink@...teo.de>
CC:     Dixit Parmar <dixitparmar19@...il.com>,
        Henrik Rydberg <rydberg@...math.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH 0/8] Face lift for st1232 touchscreen driver

Hi Dmitry,

> -----Ursprüngliche Nachricht-----
> Von: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Gesendet: Dienstag, 22. Oktober 2019 21:56
> An: Martin Kepplinger <martink@...teo.de>
> Cc: Dixit Parmar <dixitparmar19@...il.com>; Henrik Rydberg
> <rydberg@...math.org>; Kuninori Morimoto
> <kuninori.morimoto.gx@...esas.com>; Matthias Fend
> <Matthias.Fend@...fvision.net>; linux-input@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Betreff: [PATCH 0/8] Face lift for st1232 touchscreen driver
> 
> This series cleans up the driver and switches it over to the slotted
> multi-touch protocol (MT-B) that should reduce the traffic between kernel
> and userspace.
> 
> Note that I do not have hardware, so I would appreciate if you could try
> running it and tell me if it is broken or not.

Looks good. I tested the series from your st1232 branch [1] and could not see any regressions.
Note that I my 'real' application only supports ONE finger. So, the other fingers are just tested with debug output.

Thanks,
 ~Matthias

[1] git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git st1232

> 
> Thanks!
> 
> 
> Dmitry Torokhov (8):
>   Input: st1232 - simplify parsing of read buffer
>   Input: st1232 - do not unconditionally configure as wakeup source
>   Input: st1232 - rely on I2C core to configure wakeup interrupt
>   Input: st1232 - do not reset the chip too early
>   Input: st1232 - do not allocate fingers data separately
>   Input: st1232 - do not set parent device explicitly
>   Input: st1232 - note that the receive buffer is DMA-safe
>   Input: st1232 - switch to using MT-B protocol
> 
>  drivers/input/touchscreen/st1232.c | 184 ++++++++++++++---------------
>  1 file changed, 89 insertions(+), 95 deletions(-)
> 
> --
> 2.23.0.866.gb869b98d4c-goog