[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191028080113.GD1944@kadam>
Date: Mon, 28 Oct 2019 11:01:13 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Joe Perches <joe@...ches.com>
Cc: Cristiane Naves <cristianenavescardoso09@...il.com>,
outreachy-kernel@...glegroups.com, devel@...verdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org,
Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open
parenthesis
On Fri, Oct 25, 2019 at 06:50:25PM -0700, Joe Perches wrote:
> On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote:
> > Fix alignment should match open parenthesis.Issue found by checkpatch.
>
> Beyond doing style cleanups, please always try
> to make the code more readable.
>
> > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> []
> > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > precvbuf->ref_cnt = 0;
> > precvbuf->adapter = padapter;
> > list_add_tail(&precvbuf->list,
> > - &(precvpriv->free_recv_buf_queue.queue));
> > + &(precvpriv->free_recv_buf_queue.queue));
>
> Please remove the unnecessary parentheses too
>
Removing the parentheses increases your chance of the patch being
rejected on the one thing per patch rule...
regards,
dan carpenter
Powered by blists - more mailing lists