linux-kernel - Re: [EXT] [PATCH][next] net: aquantia: fix unintention integer overflow on left shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fe5fdc0-ea7a-6a4a-6453-4115adf6e2ba@marvell.com>
Date:   Mon, 28 Oct 2019 09:45:32 +0000
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Colin King <colin.king@...onical.com>,
        Egor Pomozov <epomozov@...vell.com>,
        Igor Russkikh <Igor.Russkikh@...antia.com>,
        "David S . Miller" <davem@...emloft.net>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        Sergey Samoilenko <Sergey.Samoilenko@...antia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH][next] net: aquantia: fix unintention integer
 overflow on left shift


> From: Colin Ian King <colin.king@...onical.com>
> 
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
> 
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Igor Russkikh <irusskikh@...vell.com>