linux-kernel - Re: [PATCH v2 2/8] dt-bindings: rtc: realtek: Convert RTD119x to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5491f3ed-93bf-1c4d-60f8-5d646c3bd2fb@suse.de>
Date:   Mon, 28 Oct 2019 11:46:48 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-realtek-soc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Mark Rutland <mark.rutland@....com>, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] dt-bindings: rtc: realtek: Convert RTD119x to
 schema

Am 25.10.19 um 23:20 schrieb Rob Herring:
> On Sun, Oct 20, 2019 at 06:08:11AM +0200, Andreas Färber wrote:
>> Convert the RTD119x binding to a YAML schema.
>>
>> Signed-off-by: Andreas Färber <afaerber@...e.de>
>> ---
>>  v2: New
>>  
>>  .../devicetree/bindings/rtc/realtek,rtd119x.txt    | 16 ---------
>>  .../devicetree/bindings/rtc/realtek,rtd119x.yaml   | 38 ++++++++++++++++++++++
>>  2 files changed, 38 insertions(+), 16 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt
>>  create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml
> 
> 
>> diff --git a/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml b/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml
>> new file mode 100644
>> index 000000000000..71b7396bd469
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml

While renaming the file to .yaml I would like to also rename it to 1195.
It would need to be 1x9x to cover RTD1195 and e.g. RTD1296, and looking
forward the wildcard may need to be 1xxx to cover also RTD1619, which
quickly becomes unrecognizable.

>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
> 
> Missing ()

Fixed.

> 
> Though I'm not sure it matters other than consistency.
> 
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/rtc/realtek,rtd119x.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Realtek RTD129x Real-Time Clock
>> +
>> +allOf:
>> +  - $ref: "rtc.yaml#"
>> +
>> +maintainers:
>> +  - Andreas Färber <afaerber@...e.de>
>> +
>> +properties:
>> +  compatible:
>> +    const: realtek,rtd1295-rtc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +    description: Specifies the clock gate
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +
>> +examples:
>> +  - |
>> +	rtc@...1b600 {
>> +		compatible = "realtek,rtd1295-clk";

This reveals a bug in the original binding example. Fixed to -rtc.

>> +		reg = <0x9801b600 0x100>;
>> +		clocks = <&clkc RTD1295_CLK_EN_MISC_RTC>;
> 
> You need the include file here or the example won't build (run 'make 
> dt_binding_check').

We can't. You acked the clk binding but the driver never got any review,
so it didn't get merged and cannot be depended on here.

I've changed it to an artificial 42 so that dt_binding_check passes.
I've also needed to fix the indentation to 4 spaces.

Regards,
Andreas

> 
>> +	};
>> +...
>> -- 
>> 2.16.4
>>


-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)