linux-kernel - Re: [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 13:12:47 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     emamd001@....edu, smccaman@....edu, kjlu@....edu,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cfg80211: Fix memory leak in
 cfg80211_inform_single_bss_frame_data

On Sun, 2019-10-27 at 13:15 -0500, Navid Emamdoost wrote:
> In the implementation of cfg80211_inform_single_bss_frame_data() the
> allocated memory for ies is leaked in case of an error. Release ies if
> cfg80211_bss_update() fails.

I'm pretty sure it's more complicated than this patch (and the previous
one) - we already do free this at least in the case that "new =
kzalloc(...)" fails in cfg80211_bss_update().

Your Fixes: tag is also wrong, back then we didn't even have the dynamic
allocation of the IEs.

I'm dropping this patch and the other and will make a note to eventually
look at the lifetime issue here you point out, but if you want to work
on it instead let me know.

johannes