linux-kernel - Re: [PATCH v3 1/4] crypto: Add Allwinner sun8i-ss cryptographic offloader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 14:00:28 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, davem@...emloft.net,
        herbert@...dor.apana.org.au, mark.rutland@....com,
        mripard@...nel.org, robh+dt@...nel.org, wens@...e.org
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH v3 1/4] crypto: Add Allwinner sun8i-ss cryptographic
 offloader

Hi Corentin,

On Fri, 2019-10-25 at 20:51 +0200, Corentin Labbe wrote:
> The Security System is an hardware cryptographic offloader present
> on Allwinner SoCs A80 and A83T.
> It is different from the previous sun4i-ss.
> 
> This driver supports AES cipher in CBC and ECB mode.
> 
> Acked-by: Maxime Ripard <mripard@...nel.org>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
[...]
> +static int sun8i_ss_probe(struct platform_device *pdev)
> +{
> +	struct sun8i_ss_dev *ss;
> +	int err, irq;
> +	u32 v;
> +
> +	ss = devm_kzalloc(&pdev->dev, sizeof(*ss), GFP_KERNEL);
> +	if (!ss)
> +		return -ENOMEM;
[...]
> +
> +	ss->reset = devm_reset_control_get(&pdev->dev, NULL);

It looks like this driver could use devm_reset_control_get_shared() to
get a (clk-like) refcounted reset control. Otherwise, please use
devm_reset_control_get_exclusive() instead of devm_reset_control_get().

See the kerneldoc comment for reset_control_get_shared() for details.

regards
Philipp