linux-kernel - Re: [alsa-devel] ALSA: korg1212: Checking exception handling in snd_korg1212

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ho8y1au4h.wl-tiwai@suse.de>
Date:   Mon, 28 Oct 2019 14:15:42 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Navid Emamdoost <emamd001@....edu>, alsa-devel@...a-project.org,
        Navid Emamdoost <navid.emamdoost@...il.com>,
        Kangjie Lu <kjlu@....edu>, Stephen McCamant <smccaman@....edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Richard Fontana <rfontana@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org
Subject: Re: [alsa-devel] ALSA: korg1212: Checking exception handling in snd_korg1212_create()

On Mon, 28 Oct 2019 10:00:21 +0100,
Markus Elfring wrote:
> 
> > The code path is after snd_device_new() which has its own destructor callback.
> 
> Thanks for your reminder.
> 
> Can the properties of this programming interface be documented also together
> with the function declaration for the safer handling of ALSA components?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/sound/kernel-api/writing-an-alsa-driver.rst?id=d6d5df1db6e9d7f8f76d2911707f7d5877251b02#n567

I can think of only adding some comment at each point mentioning that
the resource will be managed by the device destructor.

> Can any more API information help to improve automatic source code analysis
> around similar functions?

If anything we can add, let me know.


Takashi