linux-kernel - Re: [PATCH 3/3] drm/amd/powerplay: Make two functions static

Open Source and information security mailing list archives

Date:   Mon, 28 Oct 2019 10:06:05 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Rex Zhu <rex.zhu@....com>, "Quan, Evan" <evan.quan@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] drm/amd/powerplay: Make two functions static

On Mon, Oct 28, 2019 at 9:37 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2050:5:
>  warning: symbol 'arcturus_i2c_eeprom_control_init' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2068:6:
>  warning: symbol 'arcturus_i2c_eeprom_control_fini' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.  Thanks.  Is there more to this series?  I don't see patches 1 or 2.

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index d48a49d..3099ac2 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -2047,7 +2047,7 @@ static const struct i2c_algorithm arcturus_i2c_eeprom_i2c_algo = {
>         .functionality = arcturus_i2c_eeprom_i2c_func,
>  };
>
> -int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control)
> +static int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control)
>  {
>         struct amdgpu_device *adev = to_amdgpu_device(control);
>         int res;
> @@ -2065,7 +2065,7 @@ int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control)
>         return res;
>  }
>
> -void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control)
> +static void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control)
>  {
>         i2c_del_adapter(control);
>  }
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives