linux-kernel - Re: [PATCH] clk: hi6220: use CLK_OF_DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 08:07:12 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>
Cc:     Peter Griffin <peter.griffin@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Allison Randal <allison@...utok.net>,
        linux-clk@...r.kernel.org, John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH] clk: hi6220: use CLK_OF_DECLARE_DRIVER

Quoting John Stultz (2019-10-01 11:25:46)
> From: Peter Griffin <peter.griffin@...aro.org>
> 
> As now we also need to probe in the reset driver as well.
> 
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Allison Randal <allison@...utok.net>
> Cc: Peter Griffin <peter.griffin@...aro.org>
> Cc: linux-clk@...r.kernel.org
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  drivers/clk/hisilicon/clk-hi6220.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi6220.c b/drivers/clk/hisilicon/clk-hi6220.c
> index b2c5b6bbb1c1..63a94e1b6785 100644
> --- a/drivers/clk/hisilicon/clk-hi6220.c
> +++ b/drivers/clk/hisilicon/clk-hi6220.c
> @@ -86,7 +86,7 @@ static void __init hi6220_clk_ao_init(struct device_node *np)
>         hisi_clk_register_gate_sep(hi6220_separated_gate_clks_ao,
>                                 ARRAY_SIZE(hi6220_separated_gate_clks_ao), clk_data_ao);
>  }
> -CLK_OF_DECLARE(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init);
> +CLK_OF_DECLARE_DRIVER(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init);
>  

I'll add a comment about the reset driver to the code. Otherwise,
applied to clk-next.