linux-kernel - drm/mcde: Reconsider duplicate statement in mcde

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 18:00:04 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, David Airlie <airlied@...ux.ie>
Subject: drm/mcde: Reconsider duplicate statement in mcde_probe()

Hello,

I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339

How do you think about to delete one of them so that a duplicate assignment
can be avoided?

Regards,
Markus