linux-kernel - Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

Open Source and information security mailing list archives

Message-ID: <CADnq5_PPCFLZzMCUxW4Ofd5+A=N5s-iMURrSEj8C6V1NJhS68A@mail.gmail.com>
Date:   Mon, 28 Oct 2019 13:38:30 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Kuehling, Felix" <Felix.Kuehling@....com>,
        "Yang, Philip" <Philip.Yang@....com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        tiancyin <tianci.yin@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

On Wed, Oct 23, 2019 at 4:10 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1221:24: warning: variable adev set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:488:24: warning: variable adev set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:547:24: warning: variable adev set but not used [-Wunused-but-set-variable]
>
> It is never used, so can removed it.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index a61b0d9..ba00262 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -485,15 +485,12 @@ static int amdgpu_move_vram_ram(struct ttm_buffer_object *bo, bool evict,
>                                 struct ttm_operation_ctx *ctx,
>                                 struct ttm_mem_reg *new_mem)
>  {
> -       struct amdgpu_device *adev;
>         struct ttm_mem_reg *old_mem = &bo->mem;
>         struct ttm_mem_reg tmp_mem;
>         struct ttm_place placements;
>         struct ttm_placement placement;
>         int r;
>
> -       adev = amdgpu_ttm_adev(bo->bdev);
> -
>         /* create space/pages for new_mem in GTT space */
>         tmp_mem = *new_mem;
>         tmp_mem.mm_node = NULL;
> @@ -544,15 +541,12 @@ static int amdgpu_move_ram_vram(struct ttm_buffer_object *bo, bool evict,
>                                 struct ttm_operation_ctx *ctx,
>                                 struct ttm_mem_reg *new_mem)
>  {
> -       struct amdgpu_device *adev;
>         struct ttm_mem_reg *old_mem = &bo->mem;
>         struct ttm_mem_reg tmp_mem;
>         struct ttm_placement placement;
>         struct ttm_place placements;
>         int r;
>
> -       adev = amdgpu_ttm_adev(bo->bdev);
> -
>         /* make space in GTT for old_mem buffer */
>         tmp_mem = *new_mem;
>         tmp_mem.mm_node = NULL;
> @@ -1218,11 +1212,8 @@ static struct ttm_backend_func amdgpu_backend_func = {
>  static struct ttm_tt *amdgpu_ttm_tt_create(struct ttm_buffer_object *bo,
>                                            uint32_t page_flags)
>  {
> -       struct amdgpu_device *adev;
>         struct amdgpu_ttm_tt *gtt;
>
> -       adev = amdgpu_ttm_adev(bo->bdev);
> -
>         gtt = kzalloc(sizeof(struct amdgpu_ttm_tt), GFP_KERNEL);
>         if (gtt == NULL) {
>                 return NULL;
> --
> 2.7.4
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives