linux-kernel - Re: [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 12:01:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sheetal.tigadoli@...adcom.com
Cc:     zajec5@...il.com, gregkh@...uxfoundation.org,
        michal.simek@...inx.com, rajan.vaja@...inx.com,
        scott.branden@...adcom.com, ray.jui@...adcom.com,
        vikram.prakash@...adcom.com, jens.wiklander@...aro.org,
        michael.chan@...adcom.com, vikas.gupta@...adcom.com,
        vasundhara-v.volam@...adcom.com, linux-kernel@...r.kernel.org,
        tee-dev@...ts.linaro.org, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager

From: David Miller <davem@...emloft.net>
Date: Mon, 28 Oct 2019 11:49:15 -0700 (PDT)

> From: Sheetal Tigadoli <sheetal.tigadoli@...adcom.com>
> Date: Thu, 24 Oct 2019 11:02:38 +0530
> 
>> This patch series adds support for TEE based BNXT firmware
>> management module and the driver changes to invoke OP-TEE
>> APIs to fastboot firmware and to collect crash dump.
>> 
>> changes from v2:
>>  - address review comments from Jakub
> 
> Series applied to net-next.
> 
> Please properly annotate your Subject lines in the future to indicate
> the exact GIT tree your patches are targetting, ala "[PATCH net-next ...]"

Actually, reverted, this doesn't even compile:

drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘prepare_args’:
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function)
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
   param[0].u.memref.size = MAX_SHM_MEM_SZ;
                            ^~~~~~~~~~~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: note: each undeclared identifier is reported only once for each function it appears in
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
   param[0].u.memref.size = MAX_SHM_MEM_SZ;
                            ^~~~~~~~~~~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘tee_bnxt_fw_probe’:
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function)
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:214:44: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
  fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
                                            ^~~~~~~~~~~~~~