linux-kernel - [PATCH] scsi: csiostor: Return value not required for csio_dfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 01:12:34 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     jejb@...ux.ibm.com, martin.petersen@...cle.com, varun@...lsio.com,
        emilne@...hat.com, saurav.girepunje@...il.com,
        gregkh@...uxfoundation.org, hare@...e.de,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: [PATCH] scsi: csiostor: Return value not required for
 csio_dfs_destroy.

Only csio_hw_free() calling csio_dfs_destroy() and it is not
checking return value. So remove the return from csio_dfs_destroy().

Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
---
 drivers/scsi/csiostor/csio_init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
index a6dd704d7f2d..28b77fa8b015 100644
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -154,13 +154,11 @@ csio_dfs_create(struct csio_hw *hw)
 /*
  * csio_dfs_destroy - Destroys per-hw debugfs.
  */
-static int
+static void
 csio_dfs_destroy(struct csio_hw *hw)
 {
 	if (hw->debugfs_root)
 		debugfs_remove_recursive(hw->debugfs_root);
-
-	return 0;
 }
 
 /*
-- 
2.20.1