linux-kernel - Re: [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191028031459.GI16985@dragon>
Date:   Mon, 28 Oct 2019 11:15:00 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Anson Huang <anson.huang@....com>
Cc:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>, Jun Li <jun.li@....com>,
        Jacky Bai <ping.bai@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "ccaione@...libre.com" <ccaione@...libre.com>,
        Abel Vesa <abel.vesa@....com>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "jon@...id-run.com" <jon@...id-run.com>,
        "baruch@...s.co.il" <baruch@...s.co.il>,
        "angus@...ea.ca" <angus@...ea.ca>, "pavel@....cz" <pavel@....cz>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        Troy Kisky <troy.kisky@...ndarydevices.com>,
        Gary Bisson <gary.bisson@...ndarydevices.com>,
        "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com>,
        Richard Hu <richard.hu@...hnexion.com>,
        "andradanciu1997@...il.com" <andradanciu1997@...il.com>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
        Aisheng Dong <aisheng.dong@....com>,
        Peng Fan <peng.fan@....com>, Andy Duan <fugang.duan@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to
 board DT

On Mon, Oct 28, 2019 at 01:29:32AM +0000, Anson Huang wrote:
> Hi, Shawn
> 
> > On Wed, Oct 16, 2019 at 10:14:23AM +0800, Anson Huang wrote:
> > > usdhc's clock rate is different according to different devices
> > > connected, so clock rate assignment should be placed in board DT
> > > according to different devices connected on each usdhc port.
> > 
> > I think it should be fine that we have a reasonable default settings in soc.dtsi,
> > and boards that need a different setup can overwrite the settings in
> > board.dts.
> 
> Someone was complaining about the usdhc clock assignment in soc.dtsi, because some
> usdhc nodes are having clock assignments while some are NOT. That is why I did this
> patch set. I agree that we can have default settings in soc.dtsi, so do you think it makes
> sense to add default clock assignment to all usdhc nodes? If yes, I will redo the patch
> set.

I had a second thought on this. To ease the maintenance of soc.dtsi,
let's do clock assignments in board.dts.

Series applied, thanks.

Shawn