linux-kernel - Re: [PATCH net-next] net: dsa: qca8k: Initialize the switch with correct number of ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191028.133952.1976538256995008859.davem@davemloft.net>
Date:   Mon, 28 Oct 2019 13:39:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michal.vokac@...ft.com
Cc:     vivien.didelot@...il.com, jakub.kicinski@...ronome.com,
        andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: Initialize the switch with
 correct number of ports

From: Michal Vokáč <michal.vokac@...ft.com>
Date: Thu, 24 Oct 2019 15:46:58 +0200

> Since commit 0394a63acfe2 ("net: dsa: enable and disable all ports")
> the dsa core disables all unused ports of a switch. In this case
> disabling ports with numbers higher than QCA8K_NUM_PORTS causes that
> some switch registers are overwritten with incorrect content.
> 
> To fix this, initialize the dsa_switch->num_ports with correct number
> of ports.
> 
> Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>

Applied.