linux-kernel - phy: tegra: xusb: Complete exception handling in five probe functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe6868a4-01f5-2832-9081-7643be0ab4a1@web.de>
Date:   Mon, 28 Oct 2019 22:20:25 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-tegra@...r.kernel.org, JC Kuo <jckuo@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Thierry Reding <treding@...dia.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Kangjie Lu <kjlu@....edu>,
        Navid Emamdoost <emamd001@....edu>,
        Stephen McCamant <smccaman@....edu>
Subject: phy: tegra: xusb: Complete exception handling in five probe functions

Hello,

I have taken another look also at the implementations of five probe functions.
I have got the impression then that the exception handling is incomplete so far
at these source code places.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/phy/tegra/xusb-tegra124.c#L608
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/tegra/xusb-tegra124.c?id=8005803a2ca0af49f36f6e9329b5ecda3df27347#n608

How do you think about to move kfree() calls to other jump targets
according to the Linux coding style?

Regards,
Markus