linux-kernel - Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5DB7AD30.60007@huawei.com>
Date:   Tue, 29 Oct 2019 11:08:32 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     zhong jiang <zhongjiang@...wei.com>
CC:     <bardliao@...ltek.com>, <oder_chiou@...ltek.com>,
        <broonie@...nel.org>, <lgirdwood@...il.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static

ping.
On 2019/10/24 20:15, zhong jiang wrote:
> The GCC complains the following warning.
>
> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  sound/soc/codecs/rt5677-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
> index 36c02d2..b412371 100644
> --- a/sound/soc/codecs/rt5677-spi.c
> +++ b/sound/soc/codecs/rt5677-spi.c
> @@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
>  	mutex_unlock(&rt5677_dsp->dma_lock);
>  }
>  
> -struct page *rt5677_spi_pcm_page(
> +static struct page *rt5677_spi_pcm_page(
>  		struct snd_soc_component *component,
>  		struct snd_pcm_substream *substream,
>  		unsigned long offset)