linux-kernel - Re: [PATCH -next] net: aquantia: make two symbols be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 16:16:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     epomozov@...vell.com, igor.russkikh@...antia.com,
        pavel.belous@...antia.com, dmitry.bezrukov@...antia.com,
        dmitry.bogdanov@...antia.com, ndanilov@...antia.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] net: aquantia: make two symbols be static

From: Mao Wenan <maowenan@...wei.com>
Date: Sat, 26 Oct 2019 10:07:38 +0800

> When using ARCH=mips CROSS_COMPILE=mips-linux-gnu-
> to build drivers/net/ethernet/aquantia/atlantic/aq_ptp.o
> and drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.o,
> below errors can be seen:
> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:1378:6:
> warning: symbol 'aq_ptp_poll_sync_work_cb' was not declared.
> Should it be static?
> 
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1155:5:
> warning: symbol 'hw_atl_b0_ts_to_sys_clock' was not declared.
> Should it be static?
> 
> This patch to make aq_ptp_poll_sync_work_cb and hw_atl_b0_ts_to_sys_clock
> be static to fix these warnings.
> 
> Fixes: 9c477032f7d0 ("net: aquantia: add support for PIN funcs")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

Applied.