linux-kernel - Re: [PATCH] tpm: Add major

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191029091419.GA9896@linux.intel.com>
Date:   Tue, 29 Oct 2019 11:14:19 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Jerry Snitselaar <jsnitsel@...hat.com>,
        linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>,
        linux-integrity@...r.kernel.org
Subject: Re: [PATCH] tpm: Add major_version sysfs file

On Sun, Oct 27, 2019 at 08:00:46PM -0300, Jason Gunthorpe wrote:
> On Sun, Oct 27, 2019 at 05:35:41PM +0200, Jarkko Sakkinen wrote:
> > On Fri, Oct 25, 2019 at 07:28:47AM -0700, Jerry Snitselaar wrote:
> > > Easily determining what TCG version a tpm device implements
> > > has been a pain point for userspace for a long time, so
> > > add a sysfs file to report the tcg version of a tpm device.
> > > 
> > > Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > Cc: Peter Huewe <peterhuewe@....de>
> > > Cc: Jason Gunthorpe <jgg@...pe.ca>
> > > Cc: linux-integrity@...r.kernel.org
> > > Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>
> > 
> > Please use version_major (e.g. if there is ever version_minor
> > they order nicely alphabetically).
> 
> That is not the convention in sysfs

What is wrong with that name?

/Jarkko