linux-kernel - Re: [PATCH v2 3/3] media: hantro: Do not reorder H264 scaling list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8fe949268670586e6786eab633c389bbb6c1ed3.camel@pengutronix.de>
Date:   Tue, 29 Oct 2019 12:22:14 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Jonas Karlman <jonas@...boo.se>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Maxime Ripard <mripard@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Hans Verkuil <hverkuil@...all.nl>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Alexandre Courbot <acourbot@...omium.org>,
        Nicolas Dufresne <nicolas@...fresne.ca>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] media: hantro: Do not reorder H264 scaling list

On Tue, 2019-10-29 at 00:00 +0000, Jonas Karlman wrote:
> Scaling list supplied from userspace should be in matrix order
> and can be used without applying the inverse scanning process.
> 
> The HW also only support 8x8 scaling list for the Y component, indices 0
> and 1 in the scaling list supplied from userspace.
> 
> Remove reordering and write the scaling matrix in an order expected by
> the VPU, also only allocate memory for the two 8x8 lists supported.
> 
> Fixes: a9471e25629b ("media: hantro: Add core bits to support H264 decoding")
> Signed-off-by: Jonas Karlman <jonas@...boo.se>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp