linux-kernel - Re: [PATCH] usb: cdns3: gadget: reset EP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7f94cd4-774c-5281-4437-1a160d196bb2@ti.com>
Date:   Tue, 29 Oct 2019 14:26:23 +0200
From:   Roger Quadros <rogerq@...com>
To:     Sanket Parmar <sparmar@...ence.com>, <gregkh@...uxfoundation.org>,
        <felipe.balbi@...ux.intel.com>
CC:     <pawell@...ence.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kurahul@...ence.com>,
        <peter.chen@....com>, <nsekhar@...com>
Subject: Re: [PATCH] usb: cdns3: gadget: reset EP_CLAIMED flag while unloading



On 29/10/2019 14:24, Sanket Parmar wrote:
> EP_CLAIMED flag is used to track the claimed endpoints. While unloading the
> module, Reset EP_CLAIMED flag for all enabled endpoints. So that it can be
> reused.
> 
> Signed-off-by: Sanket Parmar <sparmar@...ence.com>

Reviewed-by: Roger Quadros <rogerq@...com>

> ---
> Hi Greg/Felipe,
> 
> This can be used for -rc as it is bug fix.
> 
> Regards,
> Sanket
> 
>   drivers/usb/cdns3/gadget.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 9050b380ab83..2fb78322ed3c 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2381,6 +2381,8 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   		writel(EP_CMD_EPRST, &priv_dev->regs->ep_cmd);
>   		readl_poll_timeout_atomic(&priv_dev->regs->ep_cmd, val,
>   					  !(val & EP_CMD_EPRST), 1, 100);
> +
> +		priv_ep->flags &= ~EP_CLAIMED;
>   	}
>   
>   	/* disable interrupt for device */
> 

-- 
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki