linux-kernel - Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 15:00:08 +0000
From:   Vincent Cheng <vincent.cheng.xh@...esas.com>
To:     Rob Herring <robh@...nel.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "richardcochran@...il.com" <richardcochran@...il.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT
 ClockMatrix based PTP clock

On Fri, Oct 25, 2019 at 03:32:28PM EDT, Rob Herring wrote:
>On Mon, Oct 21, 2019 at 03:57:47PM -0400, vincent.cheng.xh@...esas.com wrote:
>> From: Vincent Cheng <vincent.cheng.xh@...esas.com>
>> 
>> Add device tree binding doc for the IDT ClockMatrix PTP clock.
>> 
>> +
>> +examples:
>> +  - |
>> +    phc@5b {
>
>ptp@5b
>
>Examples are built now and this fails:
>
>Documentation/devicetree/bindings/ptp/ptp-idtcm.example.dts:19.15-28: 
>Warning (reg_format): /example-0/phc@5b:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
>
>The problem is i2c devices need to be shown under an i2c bus node.
>
>> +          compatible = "idt,8a34000";
>> +          reg = <0x5b>;
>> +    };

I am trying to replicate the problem locally to confirm the fix prior to re-submission.

I have tried the following:

./tools/dt-doc-validate ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
./tools/dt-extract-example ~/projects/linux/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml > example.dts

How to validate the example.dts file against the schema in ptp-idtcm.yaml?

Thanks in advance.

Regards,
Vincent