linux-kernel - Re: [PATCH v3 1/3] mm/hmm: make full use of walk_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191029174036.GR22766@mellanox.com>
Date:   Tue, 29 Oct 2019 17:40:39 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Ralph Campbell <rcampbell@...dia.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Christoph Hellwig <hch@....de>
CC:     John Hubbard <jhubbard@...dia.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] mm/hmm: make full use of walk_page_range()

On Wed, Oct 23, 2019 at 12:55:13PM -0700, Ralph Campbell wrote:
> hmm_range_fault() calls find_vma() and walk_page_range() in a loop.
> This is unnecessary duplication since walk_page_range() calls find_vma()
> in a loop already.
> Simplify hmm_range_fault() by defining a walk_test() callback function
> to filter unhandled vmas.
> This also fixes a bug where hmm_range_fault() was not checking
> start >= vma->vm_start before checking vma->vm_flags so hmm_range_fault()
> could return an error based on the wrong vma for the requested range.
> It also fixes a bug when the vma has no read access and the caller did
> not request a fault, there shouldn't be any error return code.
> 
> Signed-off-by: Ralph Campbell <rcampbell@...dia.com>
> Cc: "Jérôme Glisse" <jglisse@...hat.com>
> Cc: Jason Gunthorpe <jgg@...lanox.com>
> Cc: Christoph Hellwig <hch@....de>
>  mm/hmm.c | 126 +++++++++++++++++++++++++++----------------------------
>  1 file changed, 63 insertions(+), 63 deletions(-)

This is looking OK, can we get an ack from Jerome? Christoph?

I recall my first worry was that walk->vma could now be null, as
ops->pte_hole is set. But it looks like that is all handled now?

Thanks,
Jason