linux-kernel - Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5E00893B-D36C-446F-9E71-54FB32772DA0@lca.pw>
Date:   Wed, 30 Oct 2019 17:54:05 -0400
From:   Qian Cai <cai@....pw>
To:     "Verma, Vishal L" <vishal.l.verma@...el.com>
Cc:     "Williams, Dan J" <dan.j.williams@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Busch, Keith" <keith.busch@...el.com>,
        "Weiny, Ira" <ira.weiny@...el.com>
Subject: Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used



> On Oct 30, 2019, at 5:38 PM, Verma, Vishal L <vishal.l.verma@...el.com> wrote:
> 
> Good find! Since we're not really using rc later, we should just
> simplify this to:
> 
>    if (btt_map_write(...))
>        dev_warn_ratelimited(...)
>    goto out_rtt;

Ah, I thought about printing the rc as well at first, but it seems only return -EIO for errors, so I agree with you.