[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=X6Q3QZaND-tfYr9mf-KYMeKFmJDca3ee-i9roWj+GHsQ@mail.gmail.com>
Date: Wed, 30 Oct 2019 14:59:03 -0700
From: Doug Anderson <dianders@...omium.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Gwendal Grignou <gwendal@...omium.org>, Chao Yu <chao@...nel.org>,
Ryo Hashimoto <hashimoto@...omium.org>,
Vadim Sukhomlinov <sukhomlinov@...gle.com>,
Guenter Roeck <groeck@...omium.org>, apronin@...omium.org,
linux-doc@...r.kernel.org,
Andreas Dilger <adilger.kernel@...ger.ca>,
"Theodore Y. Ts'o" <tytso@....edu>,
Jonathan Corbet <corbet@....net>,
LKML <linux-kernel@...r.kernel.org>,
Jaegeuk Kim <jaegeuk@...nel.org>,
linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org,
linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH] Revert "ext4 crypto: fix to check feature status before
get policy"
Hi,
On Wed, Oct 30, 2019 at 1:57 PM Eric Biggers <ebiggers@...nel.org> wrote:
>
> FWIW, from reading the Chrome OS code, I think the code you linked to isn't
> where the breakage actually is. I think it's actually at
> https://chromium.googlesource.com/chromiumos/platform2/+/refs/heads/master/chromeos-common-script/share/chromeos-common.sh#375
> ... where an init script is using the error message printed by 'e4crypt
> get_policy' to decide whether to add -O encrypt to the filesystem or not.
>
> It really should check instead:
>
> [ -e /sys/fs/ext4/features/encryption ]
OK, I filed <https://crbug.com/1019939> and CCed all the people listed
in the cryptohome "OWNERS" file. Hopefully one of them can pick this
up as a general cleanup. Thanks!
-Doug
Powered by blists - more mailing lists