linux-kernel - Re: [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d457995b-fed3-d560-e6b3-b8fa4b0059a0@web.de>
Date:   Wed, 30 Oct 2019 09:40:55 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Zhong Shiqi <zhong.shiqi@....com.cn>, cocci@...teme.lip6.fr,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Cheng Shengyu <cheng.shengyu@....com.cn>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Himanshu Jha <himanshujha199640@...il.com>,
        Julia Lawall <julia.lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Xue Zhihong <xue.zhihong@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>
Subject: Re: [v4] coccicheck: Support search for SmPL scripts within selected
 directory hierarchy

>> Please reconsider also the section “Using Coccinelle with a single semantic patch”:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=f877bee5ea0b56c39cd0a243e113a577b5a4ef92#n151
>
> Could we add new lines?

Yes, of course.


> How about the following?

I suggest to improve the case distinction for the make (and environment)
variable “COCCI” also by adjusting the document outline.
* Empty string
* Directory selection
* File name specification

See also:
https://docutils.readthedocs.io/en/sphinx-docs/user/rst/quickstart.html#sections


> The optional make variable COCCI can be used to search SmPL scripts in a
> directory. In that case, the variable must be initialized with the name of

… it should be set to …


> directory contains SmPL scripts.

a directory which contains scripts for the semantic patch language.

Regards,
Markus