linux-kernel - Re: [PATCH v3 ] iommu/vt-d: Fix panic after kexec -p for kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191030093313.GA7254@8bytes.org>
Date:   Wed, 30 Oct 2019 10:33:13 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     John Donnelly <John.P.Donnelly@...cle.com>
Cc:     linux-kernel@...r.kernel.org, Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v3 ] iommu/vt-d: Fix panic after kexec -p for kdump

Hi John,

On Mon, Oct 21, 2019 at 09:48:10PM -0500, John Donnelly wrote:
> Fixes: 8af46c784ecfe ("iommu/vt-d: Implement is_attach_deferred iommu ops
> entry")
> Cc: stable@...r.kernel.org # v5.3+
> 
> Signed-off-by: John Donnelly <john.p.donnelly@...cle.com>
> Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>
> 
> 
> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index c4e0e4a9ee9e..f83a9a302f8e 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -2783,7 +2783,7 @@ static int identity_mapping(struct device *dev)
>  	struct device_domain_info *info;
> 
>  	info = dev->archdata.iommu;
> -	if (info && info != DUMMY_DEVICE_DOMAIN_INFO)
> +	if (info && info != DUMMY_DEVICE_DOMAIN_INFO && info !=
> DEFER_DEVICE_DOMAIN_INFO)
>  		return (info->domain == si_domain);
> 
>  	return 0;

I applied your patch for v5.4, but it needed manual fixup because your
mailer screwed up the patch format by inserting line-breaks and
converting tabs to spaces.

Please consider to setup and use 'git send-email' for your next patches.
This will get it all right and makes life easier for maintainers that
want to apply your patches.

Thanks,

	Joerg