linux-kernel - Re: [PATCH] fault-inject: use DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umygBcEic4HXCWfFKj0ZJHo8RRzPkO959051eYoH7y4C39A@mail.gmail.com>
Date:   Wed, 30 Oct 2019 19:29:55 +0900
From:   Akinobu Mita <akinobu.mita@...il.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define
 debugfs fops

2019年10月30日(水) 17:26 zhong jiang <zhongjiang@...wei.com>:
>
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  lib/fault-inject.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 8186ca8..4e61326 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -164,7 +164,7 @@ static int debugfs_ul_get(void *data, u64 *val)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
>
>  static void debugfs_create_ul(const char *name, umode_t mode,
>                               struct dentry *parent, unsigned long *value)

Nowadays we have debugfs_create_ulong(), so should we use it instead of
debugfs_create_ul() defined in this file and remove the definision
altogether?